Summary: | [GTK] Layout Tests for experimental <attachment> element are failing since added | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marcos ChavarrÃa Teijeiro (irc: chavaone) <chavarria1991> | ||||
Component: | Tools / Tests | Assignee: | Arcady Goldmints-Orlov <crzwdjk> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboya, bugs-noreply, chavarria1991, clopez, crzwdjk, lmoura, mcatanzaro, sam, thorton, webkit-bug-importer, zan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Marcos ChavarrÃa Teijeiro (irc: chavaone)
2015-02-17 05:23:24 PST
For what it's worth, the tests all fail because the attachment element is not enabled on GTK. FWIW I would expect Gtk to skip all of fast/attachment; it's not a web-exposed feature nor one that I imagine you need? *** Bug 177534 has been marked as a duplicate of this bug. *** *** Bug 142268 has been marked as a duplicate of this bug. *** *** Bug 142269 has been marked as a duplicate of this bug. *** *** Bug 191402 has been marked as a duplicate of this bug. *** *** Bug 212199 has been marked as a duplicate of this bug. *** *** Bug 194009 has been marked as a duplicate of this bug. *** (In reply to Tim Horton from comment #2) > FWIW I would expect Gtk to skip all of fast/attachment; it's not a > web-exposed feature nor one that I imagine you need? So... what is HTML attachment element? I'm curious that we have an HTML element that is not web-exposed? Is it something private for Mac applications only? (In reply to Michael Catanzaro from comment #9) > (In reply to Tim Horton from comment #2) > > FWIW I would expect Gtk to skip all of fast/attachment; it's not a > > web-exposed feature nor one that I imagine you need? > > So... what is HTML attachment element? I'm curious that we have an HTML > element that is not web-exposed? > > Is it something private for Mac applications only? For apps (both iOS and macOS), yes; it represents a 'file' in the contenteditable area in Mail. It should probably be skipped in the global expectations then, and unskipped in Cocoa port expectations, so that every port doesn't have to skip it separately. I agree! (and am surprised it's not already that way) (In reply to Tim Horton from comment #12) > I agree! (and am surprised it's not already that way) (I think we really should consider proposing <attachment> for actual web usage, perhaps under a different name, at some point. It seems like it could have its uses). Likely! Could be useful for mail/notes/etc. web apps. I think it would need a significantly expanded JS interface, though; the way it shook out requires a lot of interaction to happen through the native API, sadly. Not shocked, just disappointed. Created attachment 442887 [details]
[fast-cq] Patch
For now I would like to just mark the tests as skipped on GLIB and close this bug. If and when the attachment element gets on track to standardization, we can open another bug for its implementation on glib platforms. Committed r285066 (243708@main): <https://commits.webkit.org/243708@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442887 [details]. |