Bug 141673

Summary: The wrong element's style is used for text-decoration-style
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, esprehn+autocc, glenn, jcraig, jdiggs, kondapallykalyan, mario, mmaxfield, samuel_white
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
Patch that works on iOS
none
Patch that works on iOS dino: review+

Dave Hyatt
Reported 2015-02-16 15:55:42 PST
It should behave like colors and be drawn from the enclosing decorating box's style.
Attachments
Patch (18.64 KB, patch)
2015-02-16 15:58 PST, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Patch that works on iOS (19.64 KB, patch)
2015-02-17 10:57 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch that works on iOS (19.93 KB, patch)
2015-02-17 10:58 PST, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-02-16 15:58:01 PST
Created attachment 246694 [details] Patch
Alexey Proskuryakov
Comment 2 2015-02-16 17:01:39 PST
/Volumes/Data/EWS/WebKit/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1768:19: error: no member named 'getTextDecorationColors' in 'WebCore::RenderObject' renderer->getTextDecorationColors(decor, underline, overline, linethrough); ~~~~~~~~ ^ 1 error generated.
Dave Hyatt
Comment 3 2015-02-17 10:57:29 PST
Created attachment 246755 [details] Patch that works on iOS
Dave Hyatt
Comment 4 2015-02-17 10:58:23 PST
Created attachment 246756 [details] Patch that works on iOS
Dave Hyatt
Comment 5 2015-02-18 11:01:11 PST
Fixed in r180273.
Note You need to log in before you can comment on or make changes to this bug.