Summary: | Develop/Disable Caches does not properly disable disk cache | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, mitz | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2015-02-16 01:36:15 PST
Created attachment 246639 [details]
patch
Created attachment 246648 [details]
with test
Comment on attachment 246648 [details] with test Clearing flags on attachment: 246648 Committed r180149: <http://trac.webkit.org/changeset/180149> All reviewed patches have been landed. Closing bug. Comment on attachment 246648 [details] with test View in context: https://bugs.webkit.org/attachment.cgi?id=246648&action=review > LayoutTests/http/tests/cache/resources/cache-test.js:104 > + }, 100); This is unlikely to be the right thing. Nothing in the tests can ever be guaranteed to take 100ms at most. On a busy machine, and with hyperthreading, there are a lot longer delays. (In reply to comment #6) > > LayoutTests/http/tests/cache/resources/cache-test.js:104 > > + }, 100); > > This is unlikely to be the right thing. Nothing in the tests can ever be > guaranteed to take 100ms at most. On a busy machine, and with > hyperthreading, there are a lot longer delays. There shouldn't be anything timing dependent in cache operations anymore. If this makes the test flaky then that indicates a bug. I still keep some delay so that we don't end up testing the in-memory write cache only. |