Bug 141636 – Develop/Disable Caches does not properly disable disk cache

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

This uses cache model which is not passed to the network process.

[Antti Koivisto]

<rdar://problem/19786151>

[Antti Koivisto]

Created attachment 246639 [details]
patch

[Antti Koivisto]

Created attachment 246648 [details]
with test

[WebKit Commit Bot]

Comment on attachment 246648 [details]
with test

Clearing flags on attachment: 246648

Committed r180149: <http://trac.webkit.org/changeset/180149>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Comment on attachment 246648 [details]
with test

View in context: https://bugs.webkit.org/attachment.cgi?id=246648&action=review

> LayoutTests/http/tests/cache/resources/cache-test.js:104
> +        }, 100);

This is unlikely to be the right thing. Nothing in the tests can ever be guaranteed to take 100ms at most. On a busy machine, and with hyperthreading, there are a lot longer delays.

[Antti Koivisto]

(In reply to comment #6)
> > LayoutTests/http/tests/cache/resources/cache-test.js:104
> > +        }, 100);
> 
> This is unlikely to be the right thing. Nothing in the tests can ever be
> guaranteed to take 100ms at most. On a busy machine, and with
> hyperthreading, there are a lot longer delays.

There shouldn't be anything timing dependent in cache operations anymore. If this makes the test flaky then that indicates a bug.

[Antti Koivisto]

I still keep some delay so that we don't end up testing the in-memory write cache only.