Bug 141629

Summary: CSS JIT: finish :nth-last-child()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=141695
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-mavericks
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch none

Benjamin Poulain
Reported 2015-02-15 18:27:28 PST
CSS JIT: finish :nth-last-child()
Attachments
Patch (705.06 KB, patch)
2015-02-15 18:42 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (529.71 KB, application/zip)
2015-02-15 19:31 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (695.61 KB, application/zip)
2015-02-15 19:36 PST, Build Bot 		no flags
Details
Patch (710.17 KB, patch)
2015-02-15 23:48 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-02-15 18:42:59 PST
Created attachment 246630 [details] Patch
Build Bot
Comment 2 2015-02-15 19:31:22 PST
Comment on attachment 246630 [details] Patch Attachment 246630 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5994256032333824 New failing tests: fast/selectors/several-nth-last-child.html
Build Bot
Comment 3 2015-02-15 19:31:25 PST
Created attachment 246632 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-02-15 19:36:12 PST
Comment on attachment 246630 [details] Patch Attachment 246630 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5539847418675200 New failing tests: fast/selectors/several-nth-last-child.html
Build Bot
Comment 5 2015-02-15 19:36:15 PST
Created attachment 246633 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Benjamin Poulain
Comment 6 2015-02-15 23:48:40 PST
Created attachment 246636 [details] Patch
Andreas Kling
Comment 7 2015-02-16 14:22:47 PST
Comment on attachment 246636 [details] Patch r=me As we discussed in person, I think we should make querySelector() ignore the parsing-is-finished state and operate on whatever the current state of the DOM is at that point. I see no reason that e.g a synchronous script that runs during parse shouldn't have a fully-functioning querySelector().
Benjamin Poulain
Comment 8 2015-02-16 20:27:13 PST
Comment on attachment 246636 [details] Patch Clearing flags on attachment: 246636 Committed r180206: <http://trac.webkit.org/changeset/180206>
Benjamin Poulain
Comment 9 2015-02-16 20:27:18 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 10 2015-02-16 21:48:44 PST
fast/selectors/nth-last-child-of-register-requirement.html times out in debug builds: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fselectors%2Fnth-last-child-of-register-requirement.html
Alexey Proskuryakov
Comment 11 2015-02-16 22:41:05 PST
Filed bug 141695.
Note You need to log in before you can comment on or make changes to this bug.