| Summary: | CSS JIT: finish :nth-last-child() | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, kling, rniwa | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=141695 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Benjamin Poulain
2015-02-15 18:27:28 PST
Created attachment 246630 [details]
Patch
Comment on attachment 246630 [details] Patch Attachment 246630 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5994256032333824 New failing tests: fast/selectors/several-nth-last-child.html Created attachment 246632 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 246630 [details] Patch Attachment 246630 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5539847418675200 New failing tests: fast/selectors/several-nth-last-child.html Created attachment 246633 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 246636 [details]
Patch
Comment on attachment 246636 [details]
Patch
r=me
As we discussed in person, I think we should make querySelector() ignore the parsing-is-finished state and operate on whatever the current state of the DOM is at that point.
I see no reason that e.g a synchronous script that runs during parse shouldn't have a fully-functioning querySelector().
Comment on attachment 246636 [details] Patch Clearing flags on attachment: 246636 Committed r180206: <http://trac.webkit.org/changeset/180206> All reviewed patches have been landed. Closing bug. fast/selectors/nth-last-child-of-register-requirement.html times out in debug builds: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fselectors%2Fnth-last-child-of-register-requirement.html Filed bug 141695. |