Bug 141577

Summary:

REGRESSION(r180060) New js/regress-141098 test crashes when LLInt is disabled.

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

141098

Attachments:

Description	Flags
Patch	benjamin: review+

Description Michael Saboff 2015-02-13 14:33:56 PST

jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: Regression test for https://webkit.org/b/141098. Make sure eval() properly handles running out of stack space. This test should run without crashing.
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: 
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: 
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: 
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: test_script_9825: line 2:  1584 Segmentation fault      "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --enableFunctionDotArguments\=true --useLLInt\=false resources/standalone-pre.js regress-141098.js resources/standalone-post.js
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: ERROR: Unexpected exit code: 139
FAIL: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint

Need to make a similar stack check to the Baseline JIT.

Comment 1 Michael Saboff 2015-02-13 14:39:44 PST

Created attachment 246550 [details]
Patch

Comment 2 Benjamin Poulain 2015-02-13 14:44:39 PST

Comment on attachment 246550 [details]
Patch

rs=me

Comment 3 Michael Saboff 2015-02-13 14:46:54 PST

Committed r180083: <http://trac.webkit.org/changeset/180083>