Bug 141553

Summary: Call updateMargins() from RenderListMarker::layout()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch none

Chris Dumez
Reported 2015-02-12 22:17:47 PST
Call updateMargins() from RenderListMarker::layout() instead of computePreferredLogicalWidths().
Attachments
WIP Patch (1.24 KB, patch)
2015-02-12 22:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-02-12 22:18:31 PST
Created attachment 246509 [details] WIP Patch
WebKit Commit Bot
Comment 2 2015-02-12 22:19:40 PST
Attachment 246509 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderListMarker.cpp:1529: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderListMarker.cpp:1643: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.