Bug 141518

Summary: [buildbot] Enable run-api-tests on release Mac bots
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, barraclough, commit-queue, ggaren, lforschler, ossy, rniwa, simon.fraser, slewis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-02-12 09:55:50 PST
http://trac.webkit.org/changeset/112734 disabled it long long time ago due to bug82652. I tested locally, it works fine on my Mavericks machine. I think it works everywhere, but you might simply forgot to reenable this test on the release bots. Please double check.
Attachments
Patch (3.36 KB, patch)
2015-02-12 09:59 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.45 KB, patch)
2015-02-12 11:45 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-02-12 09:59:10 PST
Created attachment 246449 [details] Patch Enable run-api-tests and minor cleanups: pass --no-build unconditionally and remove RunUnitTests() step from the TestFactory which isn't used by Mac and Win.
Alexey Proskuryakov
Comment 2 2015-02-12 11:38:32 PST
I am not aware of any intentional fix that would have addressed the problem. Looking at related bugs, I see a comment that this may have been fixed by making gtest build with libc++. Stephanie, can you confirm, and clean up the state of bug 82652 and rdar://problem/11149812?
Csaba Osztrogonác
Comment 3 2015-02-12 11:45:41 PST
Created attachment 246458 [details] Patch typo fixed in the changelog (bug title(
WebKit Commit Bot
Comment 4 2015-02-14 00:56:36 PST
Comment on attachment 246458 [details] Patch Clearing flags on attachment: 246458 Committed r180106: <http://trac.webkit.org/changeset/180106>
WebKit Commit Bot
Comment 5 2015-02-14 00:56:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.