Bug 141492

Summary: extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: Tools / TestsAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Rowe (bdash)
Reported 2015-02-11 14:16:57 PST
extract-localizable-strings.pl is typically run unconditionally during the build since it's difficult to get the dependencies right. The current behavior results in the output file always being updated, which results in Xcode always needing to copy the file into the framework. This has a flow-on effect of causing any dependent targets to be relinked against the framework. There are two ways to address this: 1) Only run extract-localizable-strings.pl if any of the files it considers have changed. This is difficult to arrange for with Xcode's build system, and would be cumbersome even with make. 2) Only update the target file if the new localizable strings are different from the existing localizable strings. This patch will take option 2.
Attachments
Patch (2.29 KB, patch)
2015-02-11 14:21 PST, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2015-02-11 14:21:48 PST
Created attachment 246415 [details] Patch
WebKit Commit Bot
Comment 2 2015-02-11 15:14:36 PST
Comment on attachment 246415 [details] Patch Clearing flags on attachment: 246415 Committed r179970: <http://trac.webkit.org/changeset/179970>
WebKit Commit Bot
Comment 3 2015-02-11 15:14:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.