Bug 141477

Summary:

Support ::marker pseudo-element

Product:

WebKit

Reporter:

Kyli <Kyli>

Component:

CSS

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

buildbot, contact, dbates, hyatt, Kyli, laura.timmel, rniwa, simon.fraser, webkit-bug-importer, webkit

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

URL:

https://www.w3.org/TR/css-lists-3/#marker-pseudo-element

See Also:

https://bugs.webkit.org/show_bug.cgi?id=204163

Attachments:

Description	Flags
Work-in-progress patch	none
Patch and layout tests (without compile-time guard)	none
Patch and layout tests (without compile-time guard)	none
Patch and layout tests (with compile-time guard)	none
Patch and layout tests (with compile-time guard)	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Patch and layout tests (without compile-time guard)	buildbot: commit-queue-
Patch and layout tests (with compile-time guard)	none
Patch and layout tests (with compile-time guard)	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch and layout tests (without compile-time guard)	none

Kyli

Reported 2015-02-11 10:02:30 PST

URLs: http://stackoverflow.com/q/76564/453435, http://www.w3.org/TR/css3-lists/#marker-pseudo-element Steps to reproduce the problem: 1. Create a webpage with bulleted lists. Do not use any stylesheets that remove the markers from lists. 2. Create a CSS stylesheet that specifies, using the ::marker pseudo-element, how these markers should look/behave, as specified by the W3C CSS3 Working Draft. Expected result: Markers are modified as specified. Actual result: Markers remain unmodified.

Attachments
Work-in-progress patch (23.55 KB, patch) 2017-07-25 17:10 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and layout tests (without compile-time guard) (28.68 KB, patch) 2017-07-26 13:55 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and layout tests (without compile-time guard) (28.71 KB, patch) 2017-07-26 13:58 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and layout tests (with compile-time guard) (73.43 KB, patch) 2017-07-26 13:59 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and layout tests (with compile-time guard) (80.56 KB, patch) 2017-07-26 14:16 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.14 MB, application/zip) 2017-07-26 15:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.27 MB, application/zip) 2017-07-26 15:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.76 MB, application/zip) 2017-07-26 15:53 PDT, Build Bot	no flags	Details
Patch and layout tests (without compile-time guard) (24.12 KB, patch) 2017-07-31 10:07 PDT, Daniel Bates	buildbot: commit-queue-	Details Formatted Diff Diff
Patch and layout tests (with compile-time guard) (81.74 KB, patch) 2017-07-31 10:19 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and layout tests (with compile-time guard) (81.12 KB, patch) 2017-07-31 10:20 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (986.75 KB, application/zip) 2017-07-31 11:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.35 MB, application/zip) 2017-07-31 11:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.77 MB, application/zip) 2017-07-31 11:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (983.90 KB, application/zip) 2017-07-31 11:47 PDT, Build Bot	no flags	Details
Patch and layout tests (without compile-time guard) (29.18 KB, patch) 2017-07-31 14:05 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

Steven Vachon

Comment 1 2017-02-21 07:37:11 PST

Do it.

Daniel Bates

Comment 2 2017-07-25 17:10:50 PDT

Created attachment 316407 [details] Work-in-progress patch Work-in-progress patch. The CSS Lists Module Level 3 is still in flux with regards to extended capabilities for ::marker. It does define and refer to CSS Pseudo-Elements Module Level 4 with reagrds to an initial definition for ::marker. I implemented this initial definition. I did not guard ::marker behind a runtime/compile-time flag. I will look into that shortly.

Daniel Bates

Comment 3 2017-07-25 17:11:25 PDT

One issue I ran into when writing the included test, http/wpt/css/css-pseudo-4/marker-font-properties.html, is that the baseline position of a marker with a font-size differs from the baseline position of a list item with the same font-size (why?). For now, I added a dummy <span> in http/wpt/css/css-pseudo-4/marker-font-properties.html so that the result will match the expected rendering of http/wpt/css/css-pseudo-4/marker-font-properties-expected.html. I plan to submit all the included tests in http/wpt/css/css-pseudo-4 to the Web Platform Tests repository either before or after this patch is landed. If it is before this patch lands then I will update this patch to import the submitted Web Platform Tests. Otherwise, I will do this in a follow up bug.

Daniel Bates

Comment 4 2017-07-26 13:55:32 PDT

Created attachment 316473 [details] Patch and layout tests (without compile-time guard)

Daniel Bates

Comment 5 2017-07-26 13:58:07 PDT

Created attachment 316475 [details] Patch and layout tests (without compile-time guard)

Daniel Bates

Comment 6 2017-07-26 13:59:17 PDT

Created attachment 316476 [details] Patch and layout tests (with compile-time guard)

Build Bot

Comment 7 2017-07-26 14:01:45 PDT Comment hidden (obsolete)

Attachment 316476 [details] did not pass style-queue: ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 8 2017-07-26 14:16:25 PDT

Created attachment 316479 [details] Patch and layout tests (with compile-time guard)

Build Bot

Comment 9 2017-07-26 15:36:08 PDT Comment hidden (obsolete)

Comment on attachment 316479 [details] Patch and layout tests (with compile-time guard) Attachment 316479 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4192588 New failing tests: inspector/css/shadow-scoped-style.html

Build Bot

Comment 10 2017-07-26 15:36:10 PDT Comment hidden (obsolete)

Created attachment 316490 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-07-26 15:42:13 PDT Comment hidden (obsolete)

Comment on attachment 316479 [details] Patch and layout tests (with compile-time guard) Attachment 316479 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4192604 New failing tests: inspector/css/shadow-scoped-style.html

Build Bot

Comment 12 2017-07-26 15:42:15 PDT Comment hidden (obsolete)

Created attachment 316491 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-07-26 15:53:50 PDT Comment hidden (obsolete)

Comment on attachment 316479 [details] Patch and layout tests (with compile-time guard) Attachment 316479 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4192621 New failing tests: inspector/css/shadow-scoped-style.html

Build Bot

Comment 14 2017-07-26 15:53:54 PDT Comment hidden (obsolete)

Created attachment 316493 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Daniel Bates

Comment 15 2017-07-31 10:07:29 PDT

Created attachment 316786 [details] Patch and layout tests (without compile-time guard)

Daniel Bates

Comment 16 2017-07-31 10:19:06 PDT

Created attachment 316787 [details] Patch and layout tests (with compile-time guard)

Daniel Bates

Comment 17 2017-07-31 10:20:18 PDT

Created attachment 316788 [details] Patch and layout tests (with compile-time guard)

Build Bot

Comment 18 2017-07-31 11:18:31 PDT Comment hidden (obsolete)

Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4229953 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html

Build Bot

Comment 19 2017-07-31 11:18:33 PDT Comment hidden (obsolete)

Created attachment 316790 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 20 2017-07-31 11:23:16 PDT Comment hidden (obsolete)

Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4229965 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html

Build Bot

Comment 21 2017-07-31 11:23:18 PDT Comment hidden (obsolete)

Created attachment 316791 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 22 2017-07-31 11:39:26 PDT Comment hidden (obsolete)

Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4229977 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html

Build Bot

Comment 23 2017-07-31 11:39:28 PDT Comment hidden (obsolete)

Created attachment 316792 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 24 2017-07-31 11:47:46 PDT Comment hidden (obsolete)

Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4229989 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html

Build Bot

Comment 25 2017-07-31 11:47:47 PDT Comment hidden (obsolete)

Created attachment 316793 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Daniel Bates

Comment 26 2017-07-31 14:05:39 PDT

Created attachment 316800 [details] Patch and layout tests (without compile-time guard)

Dave Hyatt

Comment 27 2017-08-02 11:52:26 PDT

Comment on attachment 316800 [details] Patch and layout tests (without compile-time guard) r=me

Daniel Bates

Comment 28 2017-08-03 09:16:55 PDT

Comment on attachment 316800 [details] Patch and layout tests (without compile-time guard) Clearing flags on attachment: 316800 Committed r220207: <http://trac.webkit.org/changeset/220207>

Daniel Bates

Comment 29 2017-08-03 09:16:57 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 30 2017-08-03 09:17:58 PDT

<rdar://problem/33701307>

Note You need to log in before you can comment on or make changes to this bug.