Bug 141445

Summary:

New perf dashboard shouldn't always show outliers

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

141237

Attachments:

Description	Flags
Fixes the bug	cdumez: review+

Description Ryosuke Niwa 2015-02-10 15:04:46 PST

It's inconvenient to always show outliners.
Use a moving average's envelope to compute the y-axis range to show instead.

Comment 1 Ryosuke Niwa 2015-02-10 15:19:29 PST

Created attachment 246348 [details]
Fixes the bug

Comment 2 Chris Dumez 2015-02-10 15:25:30 PST

Comment on attachment 246348 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=246348&action=review

r=me with 1 fix.

> Websites/perf.webkit.org/public/v2/app.js:493
> +            chartData.hideEnveope = true;

hideEnveope -> hideEnvelope

> Websites/perf.webkit.org/public/v2/interactive-chart.js:358
> +            currentRange[0] = Math.min(0, currentRange[0]);

So currentRange[0] can be negative?

Comment 3 Ryosuke Niwa 2015-02-10 18:35:41 PST

(In reply to comment #2)
> Comment on attachment 246348 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246348&action=review
> 
> r=me with 1 fix.

Thanks!

> > Websites/perf.webkit.org/public/v2/app.js:493
> > +            chartData.hideEnveope = true;
> 
> hideEnveope -> hideEnvelope

Fixed.

> > Websites/perf.webkit.org/public/v2/interactive-chart.js:358
> > +            currentRange[0] = Math.min(0, currentRange[0]);
> 
> So currentRange[0] can be negative?

Yes. There's nothing that prevents a perf. test from reporting a negative number.

Comment 4 Ryosuke Niwa 2015-02-10 18:45:43 PST

Committed r179913: <http://trac.webkit.org/changeset/179913>