Bug 14142

Summary: SVG text gradients are busted on feature-branch
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the fix zimmermann: review+

Eric Seidel (no email)
Reported 2007-06-14 12:21:51 PDT
SVG text gradients are busted on feature-branch This happened due to my adding painting outline support. The one-line fix is thus: Index: rendering/SVGRootInlineBox.cpp =================================================================== --- rendering/SVGRootInlineBox.cpp (revision 23529) +++ rendering/SVGRootInlineBox.cpp (working copy) @@ -112,7 +113,7 @@ void SVGRootInlineBox::paint(RenderObject::PaintInfo& paintInfo, int tx, int ty) { - if (paintInfo.context->paintingDisabled()) + if (paintInfo.context->paintingDisabled() || paintInfo.phase != PaintPhaseForeground) return; FloatRect boundingBox; I don't think the root inline box needs to ever paint in any other phase. I also did a small amount of clenaup in this patch.
Attachments
the fix (10.62 KB, patch)
2007-06-14 12:23 PDT, Eric Seidel (no email) 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-06-14 12:23:22 PDT
Created attachment 15027 [details] the fix
Nikolas Zimmermann
Comment 2 2007-06-14 12:26:31 PDT
Comment on attachment 15027 [details] the fix Looks good. Nice work!
Nikolas Zimmermann
Comment 3 2007-06-14 15:38:29 PDT
Landed in r23533.
Note You need to log in before you can comment on or make changes to this bug.