SVG text gradients are busted on feature-branch

• Component: SVG
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

SVG text gradients are busted on feature-branch

This happened due to my adding painting outline support.  The one-line fix is thus:

Index: rendering/SVGRootInlineBox.cpp
===================================================================
--- rendering/SVGRootInlineBox.cpp      (revision 23529)
+++ rendering/SVGRootInlineBox.cpp      (working copy)
@@ -112,7 +113,7 @@
 
 void SVGRootInlineBox::paint(RenderObject::PaintInfo& paintInfo, int tx, int ty)
 {
-    if (paintInfo.context->paintingDisabled())
+    if (paintInfo.context->paintingDisabled() || paintInfo.phase != PaintPhaseForeground)
         return;
 
     FloatRect boundingBox;

I don't think the root inline box needs to ever paint in any other phase.

I also did a small amount of clenaup in this patch.

[Eric Seidel (no email)]

Created attachment 15027 [details]
the fix

[Nikolas Zimmermann]

Comment on attachment 15027 [details]
the fix

Looks good. Nice work!

[Nikolas Zimmermann]

Landed in r23533.