Bug 141392

Summary: [GTK] Add default color chooser implementation using GtkColorChooserDialog
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fvallee, gustavo, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98935    
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2015-02-09 10:37:08 PST
Implement WebColorPicker and enable INPUT_TYPE_COLOR by default. API to override the default implementation will be added in bug #98935
Attachments
Patch (12.93 KB, patch)
2015-02-09 10:42 PST, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-02-09 10:42:56 PST
Created attachment 246276 [details] Patch
Carlos Garcia Campos
Comment 2 2015-02-11 01:03:17 PST
Committed r179922: <http://trac.webkit.org/changeset/179922>
Carlos Garcia Campos
Comment 3 2015-02-11 01:04:12 PST
Also unskipped the input color tests when landing the patch, that I had forgotten :-)
Gustavo Noronha (kov)
Comment 4 2015-02-11 03:23:03 PST
Hah, I thought the layout tests would be independent of the platform implementation.
Carlos Garcia Campos
Comment 5 2015-02-11 03:27:18 PST
(In reply to comment #4) > Hah, I thought the layout tests would be independent of the platform > implementation. Yes, but the patch enables INPUT_TYPE_COLOR, so now we render a color button instead of a text entry and all the logic behind ENABLE(INPUT_TYPE_COLOR) works as well.
Fabien Vallée
Comment 6 2015-02-19 03:09:06 PST
FYI, webkitgtk cannot build anymore if INPUT_TYPE_COLOR is deactivated manually. For instance WebKitColorChooser is not under ENABLE(INPUT_TYPE_COLOR) compile flag but is inheriting from WebColorPickerGtk under INPUT_TYPE_COLOR. Is it done on purpose ? ( = INPUT_TYPE_COLOR is now mandatory) or should we support INPUT_TYPE_COLOR on/off ? (= INPUT_TYPE_COLOR check should be added everywhere) Thanks for your feedback :)
Carlos Garcia Campos
Comment 7 2015-02-19 03:30:10 PST
(In reply to comment #6) > FYI, webkitgtk cannot build anymore if INPUT_TYPE_COLOR is deactivated > manually. > > For instance WebKitColorChooser is not under ENABLE(INPUT_TYPE_COLOR) > compile flag but is inheriting from WebColorPickerGtk under INPUT_TYPE_COLOR. > > Is it done on purpose ? > ( = INPUT_TYPE_COLOR is now mandatory) Yes, it's on purpose, why do you want to disable it? > or should we support INPUT_TYPE_COLOR on/off ? > (= INPUT_TYPE_COLOR check should be added everywhere) > > Thanks for your feedback :)
Fabien Vallée
Comment 8 2015-02-19 05:31:35 PST
I don't want to deactivate it (though I guess I don't really need it). Anyway use the default webkitgtk configuration (INPUT_TYPE_COLOR = ON) is ok, thanks for answer.
Note You need to log in before you can comment on or make changes to this bug.