Bug 141388

Summary: Varargs frame set-up should be factored out for use by other JITs
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 141332    
Attachments:
Description Flags
the patch
none
the patch
none
the patch msaboff: review+

Description Filip Pizlo 2015-02-09 09:47:02 PST 
Currently there is a lot of code that is tightly-coupled to the baseline engines' view of the world - i.e. literal execution of bytecode.  There is even more code that does smart things for varargs that is inside the baseline JIT itself.

We should move that code out and make it more general, for example make it respect the notion that not everyone executes bytecode.
Comment 1 Filip Pizlo 2015-02-09 09:56:45 PST 
Created attachment 246274 [details]
the patch
Comment 2 Filip Pizlo 2015-02-09 10:52:41 PST 
Created attachment 246278 [details]
the patch

Some 32-bit fixes.
Comment 3 Filip Pizlo 2015-02-09 12:13:04 PST 
Created attachment 246282 [details]
the patch

32-bit works again.
Comment 4 Michael Saboff 2015-02-09 13:58:40 PST 
Comment on attachment 246282 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-02-09 19:28:05 PST 
Landed in http://trac.webkit.org/changeset/179862