Bug 141388

Summary:

Varargs frame set-up should be factored out for use by other JITs

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

141332

Attachments:

Description	Flags
the patch	none
the patch	none
the patch	msaboff: review+

Filip Pizlo

Reported 2015-02-09 09:47:02 PST

Currently there is a lot of code that is tightly-coupled to the baseline engines' view of the world - i.e. literal execution of bytecode. There is even more code that does smart things for varargs that is inside the baseline JIT itself. We should move that code out and make it more general, for example make it respect the notion that not everyone executes bytecode.

Attachments
the patch (58.30 KB, patch) 2015-02-09 09:56 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (58.54 KB, patch) 2015-02-09 10:52 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (59.36 KB, patch) 2015-02-09 12:13 PST, Filip Pizlo	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2015-02-09 09:56:45 PST

Created attachment 246274 [details] the patch

Filip Pizlo

Comment 2 2015-02-09 10:52:41 PST

Created attachment 246278 [details] the patch Some 32-bit fixes.

Filip Pizlo

Comment 3 2015-02-09 12:13:04 PST

Created attachment 246282 [details] the patch 32-bit works again.

Michael Saboff

Comment 4 2015-02-09 13:58:40 PST

Comment on attachment 246282 [details] the patch r=me

Filip Pizlo

Comment 5 2015-02-09 19:28:05 PST

Landed in http://trac.webkit.org/changeset/179862

Note You need to log in before you can comment on or make changes to this bug.