Bug 141374 – Make SVGUseElement work without creating any SVGElementInstance objects

• Component: SVG
• Status: RESOLVED FIXED

[Darin Adler]

Make SVGUseElement work without creating any SVGElementInstance objects

[Darin Adler]

Created attachment 246250 [details]
Patch

[Sam Weinig]

Comment on attachment 246250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246250&action=review

> Source/WebCore/dom/TypedElementDescendantIterator.h:83
> +template<typename ElementType> class DoubleTypedElementDescendantIteratorAdapter {

A part of me says this should really be MultipleTypedElementDescendantIteratorAdapter and use a std::tuple. Another part of me says that can wait until someone needs TripleTypedElementDescendantIteratorAdapter.

> Source/WebCore/svg/SVGUseElement.cpp:500
> +    // This can be combined with buildShadowTree.

Seems like this should either be a FIXME or just done now.

[Darin Adler]

Comment on attachment 246250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246250&action=review

>> Source/WebCore/dom/TypedElementDescendantIterator.h:83
>> +template<typename ElementType> class DoubleTypedElementDescendantIteratorAdapter {
> 
> A part of me says this should really be MultipleTypedElementDescendantIteratorAdapter and use a std::tuple. Another part of me says that can wait until someone needs TripleTypedElementDescendantIteratorAdapter.

I think I would have done it that way if I knew how.

>> Source/WebCore/svg/SVGUseElement.cpp:500
>> +    // This can be combined with buildShadowTree.
> 
> Seems like this should either be a FIXME or just done now.

Made it a FIXME.

[Darin Adler]

Committed r179807: <http://trac.webkit.org/changeset/179807>

[Alex Christensen]

Something about the associateClonesWithOriginals, associateReplacementCloneWithOriginal, and associateReplacementClonesWithOriginals helpers makes Visual Studio crash and complain that it is too complex.

[Brent Fulgham]

(In reply to comment #5)
> Something about the associateClonesWithOriginals,
> associateReplacementCloneWithOriginal, and
> associateReplacementClonesWithOriginals helpers makes Visual Studio crash
> and complain that it is too complex.

Are you seeing this locally? I have to see what EWS is complaining about.

If you are having trouble with a local build, make sure you are using VS2013 SP4. They fixed some compiler bugs that might be relevant here.

[Alex Christensen]

It also caused the buildbots to fail.  

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/85440/steps/compile-webkit/logs/stdio

SVGAllInOne.obj is probably 0 bytes because of this problem.

[Alex Christensen]

Fixed with https://bugs.webkit.org/show_bug.cgi?id=141461