Summary: | [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, darin, dbates, ddkilzer, glenn, jake.nielsen.webkit | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 141358 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2015-02-07 16:22:31 PST
Created attachment 246227 [details]
Patch v1
Comment on attachment 246227 [details]
Patch v1
This patch is OK as-is. As remarked in a comment above class Simulator in this file, we may want consider parsing the device.plist files instead of parsing the simctl output, which seems more likely to change.
Comment on attachment 246227 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=246227&action=review > Tools/Scripts/webkitpy/xcode/simulator_unittest.py:230 > + self.assertEqual('com.apple.CoreSimulator.SimRuntime.iOS-8-0', runtime_ios_8.identifier) > + self.assertEqual(True, runtime_ios_8.available) > + self.assertEqual(False, runtime_ios_8.is_internal_runtime) > + self.assertEqual(tuple([8, 0]), runtime_ios_8.version) > + self.assertEqual(1, len(runtime_ios_8.devices)) I wish there was a better way to write this. One idea is to take advantage of Runtime's equality operator __eq__, construct a expected Runtime object and then perform self.assertEqual(expected_runtime, runtime_ios_8). We may want to add logic to Runtime.__eq__ to support checking the Runtime.is_internal_runtime, or even Runtime.available. Comment on attachment 246227 [details] Patch v1 Clearing flags on attachment: 246227 Committed r179793: <http://trac.webkit.org/changeset/179793> All reviewed patches have been landed. Closing bug. |