Bug 141358

Summary:

[iOS] Make Simulator class testable

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dbates, ddkilzer, glenn, jake.nielsen.webkit, jhoneycutt, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch v1	darin: review+

David Kilzer (:ddkilzer)

Reported 2015-02-07 10:48:03 PST

Need to make the Simulator class testable so that another bug can be fixed by writing a new failing test, then fixing that test.

Attachments
Patch v1 (17.40 KB, patch) 2015-02-07 10:58 PST, David Kilzer (:ddkilzer)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2015-02-07 10:58:26 PST

Darin Adler

Comment 2 2015-02-07 11:08:55 PST

Comment on attachment 246210 [details] Patch v1 rs=me

David Kilzer (:ddkilzer)

Comment 3 2015-02-07 16:14:14 PST

Comment on attachment 246210 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=246210&action=review > Tools/Scripts/webkitpy/xcode/simulator_unittest.py:24 > +import os > +import re These imports are not needed. Will remove them before landing.

David Kilzer (:ddkilzer)

Comment 4 2015-02-07 16:44:43 PST

Note You need to log in before you can comment on or make changes to this bug.