Bug 141358

Summary:

[iOS] Make Simulator class testable

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dbates, ddkilzer, glenn, jake.nielsen.webkit, jhoneycutt, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

141365

Attachments:

Description	Flags
Patch v1	darin: review+

Description David Kilzer (:ddkilzer) 2015-02-07 10:48:03 PST

Need to make the Simulator class testable so that another bug can be fixed by writing a new failing test, then fixing that test.

Comment 1 David Kilzer (:ddkilzer) 2015-02-07 10:58:26 PST

Created attachment 246210 [details]
Patch v1

Comment 2 Darin Adler 2015-02-07 11:08:55 PST

Comment on attachment 246210 [details]
Patch v1

rs=me

Comment 3 David Kilzer (:ddkilzer) 2015-02-07 16:14:14 PST

Comment on attachment 246210 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=246210&action=review

> Tools/Scripts/webkitpy/xcode/simulator_unittest.py:24
> +import os
> +import re

These imports are not needed.  Will remove them before landing.

Comment 4 David Kilzer (:ddkilzer) 2015-02-07 16:44:43 PST

Committed r179788: <http://trac.webkit.org/changeset/179788>