Bug 141334

Summary:

Web Inspector: BasicBlockAnnotator ranges should be inclusive of both the start and end offset

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

Web Inspector

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

141095

Bug Blocks:

Attachments:

Description	Flags
the patch	joepeck: review+
patch	none

Saam Barati

Reported 2015-02-06 11:11:16 PST

This should land in concert with this JSC change: https://bugs.webkit.org/show_bug.cgi?id=141095

Attachments
the patch (1.58 KB, patch) 2015-02-06 11:47 PST, Saam Barati	joepeck: review+	Details Formatted Diff Diff
patch (1.53 KB, patch) 2015-02-10 12:05 PST, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-02-06 11:11:41 PST

<rdar://problem/19747067>

Saam Barati

Comment 2 2015-02-06 11:47:30 PST

Created attachment 246168 [details] the patch

Joseph Pecoraro

Comment 3 2015-02-06 11:50:14 PST

Comment on attachment 246168 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=246168&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TextEditor.js:464 > + var options = { Meh, could be inlined still =)

Saam Barati

Comment 4 2015-02-10 12:05:39 PST

Created attachment 246334 [details] patch Patch slightly changed. I don't think CodeMirror Actually respects the inclusiveLeft/Right options. I tried all variations of the 2^2=4 assignments to inclusiveLeft/Right and I couldn't get the text marking to behave any differently. I couldn't figure out why this is, it may be worth filing a bug with CodeMirror if this is indeed the case. Anyways, I found that if you have a text range [start, end], then the range that CodeMirror actually marks is such: [start, end). This patch compensates for this by adding one to the end position's offset.

Timothy Hatcher

Comment 5 2015-02-10 13:10:26 PST

Comment on attachment 246334 [details] patch You should file a CodeMirror bug with a simple test case.

WebKit Commit Bot

Comment 6 2015-02-23 15:18:45 PST

Comment on attachment 246334 [details] patch Clearing flags on attachment: 246334 Committed r180526: <http://trac.webkit.org/changeset/180526>

WebKit Commit Bot

Comment 7 2015-02-23 15:18:50 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.