Bug 141330

Summary: [GTK] Remove WebKitWebView::close-notification signal
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2015-02-06 05:28:07 PST
In favor of a WebKitNotification::closed signal. There are two main reasons for this: 1.- We are running out of padding space in WebKitWebViewClass 2.- Applications should be able to close notifications too. Right now, in the default implementation when the user closes a notification, the web view is not notified, so the notification remains alive and onclose handler is not dispatched either.
Attachments
Patch (23.13 KB, patch)
2015-02-06 05:42 PST, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-02-06 05:42:07 PST
Created attachment 246162 [details] Patch
Gustavo Noronha (kov)
Comment 2 2015-02-06 05:58:11 PST
Comment on attachment 246162 [details] Patch So back to having the close signal on the notification and fixing a DOM notification that was not being emitted - I wonder if there are tests that we can unskip for that?
Carlos Garcia Campos
Comment 3 2015-02-06 06:13:55 PST
(In reply to comment #2) > Comment on attachment 246162 [details] > Patch > > So back to having the close signal on the notification and fixing a DOM > notification that was not being emitted - I wonder if there are tests that > we can unskip for that? This only affects the GTK+ API, not the C API used by WTR, so I don't think this can fix any test
Carlos Garcia Campos
Comment 4 2015-02-06 06:50:34 PST
Committed r179745: <http://trac.webkit.org/changeset/179745>
Note You need to log in before you can comment on or make changes to this bug.