Bug 141312

Summary:

Dashboard doesn't consider building ASan a productive step

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dburkart

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	simon.fraser: review+

Description Alexey Proskuryakov 2015-02-05 16:08:05 PST

This breaks displaying how far behind we are, possibly more.

Comment 1 Alexey Proskuryakov 2015-02-05 16:13:03 PST

Created attachment 246136 [details]
proposed fix

I started to wonder if we should consider "build" a productive step, or "upload". Is the builder behind if it successfully built, but failed to upload, and needs to build again?

On one hand, it did tell us whether the build is broken, but on another hand, it didn't provide any binaries to testers.

This patch just keeps with tradition.

Comment 2 Simon Fraser (smfr) 2015-02-05 16:20:28 PST

Comment on attachment 246136 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246136&action=review

> Tools/ChangeLog:15
> +2015-02-05  Alexey Proskuryakov  <ap@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).

OOPS

Comment 3 Alexey Proskuryakov 2015-02-05 16:30:58 PST

Committed <http://trac.webkit.org/r179721>.