Bug 141307

Summary: [iOS] Remove False Positive dispatch_source Leak in WebMemoryPressureHandler singleton
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-02-05 14:46:45 PST
* SUMMARY
Remove False Positive OS_dispatch_source Leak in WebMemoryPressureHandler singleton.

I think we actually want to always keep this dispatch_source around. So we should just add a reference to it in WebMemoryPressureHandler.

* LEAK OUTPUT
Leak: 0x1657a1f0  size=112  zone: DefaultMallocZone_0x197e000   OS_dispatch_source  ObjC  libdispatch.dylib
	Call stack: [thread 0x3676a9d0]: 
        | start 
        | 0x4c0e1 
        | UIApplicationMain 
        | -[UIApplication _run] 
        ...
        | -[WKProcessPool(WKPrivate) _initWithConfiguration:] 
        | WebKit::WebProcessPool::WebProcessPool(API::ProcessPoolConfiguration&) 
        | WebKit::WebMemoryPressureHandler::shared() 
        | WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler() 
        | dispatch_source_create 
        | _os_object_alloc_realized 
        | class_createInstance 
        | calloc 
        | malloc_zone_calloc
Comment 1 Joseph Pecoraro 2015-02-05 14:47:38 PST
Created attachment 246132 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-02-05 15:47:41 PST
Comment on attachment 246132 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 246132

Committed r179720: <http://trac.webkit.org/changeset/179720>
Comment 3 WebKit Commit Bot 2015-02-05 15:47:45 PST
All reviewed patches have been landed.  Closing bug.