Bug 141297

Summary:

[WK2][Cocoa] Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2015-02-05 11:21:31 PST

Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize() to avoid thread-safety issues.

Comment 1 Chris Dumez 2015-02-05 11:25:51 PST

Created attachment 246116 [details]
Patch

Comment 2 Antti Koivisto 2015-02-05 13:05:43 PST

Comment on attachment 246116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246116&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:142
> +            dispatch_async(dispatch_get_main_queue(), [this, hash] {
> +                m_contentsFilter.add(hash);
> +            });

This gets called a lot so dispatching every item individually is not very optimal. But we can do better later if needed.

Comment 3 WebKit Commit Bot 2015-02-05 13:48:22 PST

Comment on attachment 246116 [details]
Patch

Clearing flags on attachment: 246116

Committed r179704: <http://trac.webkit.org/changeset/179704>

Comment 4 WebKit Commit Bot 2015-02-05 13:48:28 PST

All reviewed patches have been landed.  Closing bug.