Bug 141286

Summary:

New perf dashboard should compare results to baseline and target

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, commit-queue, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

141237

Attachments:

Description	Flags
Patch	none

Description Ryosuke Niwa 2015-02-05 00:24:43 PST

As done in the v1 dashboard, we should compare results to the baseline and the target values.

Comment 1 Ryosuke Niwa 2015-02-05 00:54:40 PST

Created attachment 246092 [details]
Patch

Comment 2 Chris Dumez 2015-02-05 13:25:13 PST

Comment on attachment 246092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246092&action=review

r=me

> Websites/perf.webkit.org/public/v2/app.js:791
> +        var formatter = d3.format('.3p');

Why don't we use the formatter from chartData?

Comment 3 WebKit Commit Bot 2015-02-05 14:34:19 PST

Comment on attachment 246092 [details]
Patch

Clearing flags on attachment: 246092

Committed r179710: <http://trac.webkit.org/changeset/179710>

Comment 4 WebKit Commit Bot 2015-02-05 14:34:24 PST

All reviewed patches have been landed.  Closing bug.