Bug 141276

Summary:

Use enum class for GraphicsLayer::ContentsLayerPurpose

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, thorton: commit-queue-

Simon Fraser (smfr)

Reported 2015-02-04 17:17:10 PST

Use enum class for GraphicsLayer::ContentsLayerPurpose

Attachments
Patch (9.33 KB, patch) 2015-02-04 17:17 PST, Simon Fraser (smfr)	thorton: review+ thorton: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2015-02-04 17:17:41 PST

Created attachment 246070 [details] Patch

Tim Horton

Comment 2 2015-02-04 17:43:06 PST

Comment on attachment 246070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246070&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:230 > + NoLayer = 0, "None"?

Alexey Proskuryakov

Comment 3 2015-02-04 20:25:59 PST

iOS EWS says: /Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:3447:78: error: no member named 'ContentsLayerForMedia' in 'WebCore::GraphicsLayer'; did you mean 'contentsLayerForMedia'?

Ahmad Saleem

Comment 4 2022-10-10 09:47:50 PDT

Already done - https://github.com/WebKit/WebKit/blob/6ca6aad73c5b205af1070332ff2a3faba9db5627/Source/WebCore/platform/graphics/GraphicsLayer.h#L510 https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1227 https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1239 https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1264 etc. I think we can close this.

Note You need to log in before you can comment on or make changes to this bug.