Bug 141276

Summary:

Use enum class for GraphicsLayer::ContentsLayerPurpose

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, thorton: commit-queue-

Description Simon Fraser (smfr) 2015-02-04 17:17:10 PST

Use enum class for GraphicsLayer::ContentsLayerPurpose

Comment 1 Simon Fraser (smfr) 2015-02-04 17:17:41 PST

Created attachment 246070 [details]
Patch

Comment 2 Tim Horton 2015-02-04 17:43:06 PST

Comment on attachment 246070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246070&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:230
> +        NoLayer = 0,

"None"?

Comment 3 Alexey Proskuryakov 2015-02-04 20:25:59 PST

iOS EWS says:

/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:3447:78: error: no member named 'ContentsLayerForMedia' in 'WebCore::GraphicsLayer'; did you mean 'contentsLayerForMedia'?

Comment 4 Ahmad Saleem 2022-10-10 09:47:50 PDT

Already done - https://github.com/WebKit/WebKit/blob/6ca6aad73c5b205af1070332ff2a3faba9db5627/Source/WebCore/platform/graphics/GraphicsLayer.h#L510

https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1227

https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1239

https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1264

etc.

I think we can close this.