| Summary: | LayoutTestHelper should set the color profile of all displays | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, simon.fraser, thorton | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2015-02-04 14:01:03 PST
Created attachment 246046 [details]
Patch
Created attachment 246047 [details]
Patch
Comment on attachment 246046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246046&action=review > Tools/DumpRenderTree/mac/LayoutTestHelper.m:58 > + CFUUIDRef uuid = CFUUIDCreateFromString(kCFAllocatorDefault, (__bridge CFStringRef)displayUUIDString); Leak. > Tools/DumpRenderTree/mac/LayoutTestHelper.m:82 > + static const uint32_t maxDisplayCount = 10; :| > Tools/DumpRenderTree/mac/LayoutTestHelper.m:98 > + CFUUIDRef displayUUIDRef = CGDisplayCreateUUIDFromDisplayID(displayIDs[i]); leak here too > Tools/DumpRenderTree/mac/LayoutTestHelper.m:124 > + CFUUIDRef uuid = CFUUIDCreateFromString(kCFAllocatorDefault, (__bridge CFStringRef)displayUUIDString); yep > Tools/DumpRenderTree/mac/LayoutTestHelper.m:132 > + NSMutableDictionary* userColorProfiles = originalColorProfileURLs(); star's on the wrong side > Tools/DumpRenderTree/mac/LayoutTestHelper.m:149 > + // space of the display), we force the generic RGB color profile on all displays. This should say SRGB. Created attachment 246052 [details]
No more ARC
Comment on attachment 246052 [details] No more ARC View in context: https://bugs.webkit.org/attachment.cgi?id=246052&action=review > Tools/DumpRenderTree/mac/LayoutTestHelper.m:138 > + NSMutableDictionary* userColorProfiles = originalColorProfileURLs(); Star's on the wrong side. > Tools/DumpRenderTree/mac/LayoutTestHelper.m:155 > + // space of the display), we force the generic sRGB color profile on all displays. not generic :D |