Bug 141236

Summary: When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2015-02-03 23:44:42 PST
Right now, leaks bot fails with the below error and no leaks: "Exiting early after 50 crashes and 0 timeouts. 2655 tests run. 50 failures" This shouldn't be green.
Attachments
proposed fix (2.04 KB, patch)
2015-02-03 23:47 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-02-03 23:47:59 PST
Created attachment 246022 [details] proposed fix If we ever get the leaks bot to a state where there are no leaks at all, but failures do happen, this can be further tweaked to not show orange. This is too far away into the future to care about now.
WebKit Commit Bot
Comment 2 2015-02-04 10:00:05 PST
Comment on attachment 246022 [details] proposed fix Clearing flags on attachment: 246022 Committed r179608: <http://trac.webkit.org/changeset/179608>
WebKit Commit Bot
Comment 3 2015-02-04 10:00:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.