Summary: | Web Inspector: Populate Debugger sidebar with all debuggable resources | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||
Component: | Web Inspector | Assignee: | Jonathan Wells <jonowells> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2015-02-03 22:16:57 PST
Created attachment 247536 [details]
[PATCH] Progress patch for feedback.
Please review progress so far. Screenshot to follow. Working on isolating evaled scripts generated by the WebInspector front-end from those generated by the user's code.
Created attachment 247537 [details]
[SCREENSHOT] all scripts in the debugger sidebar
First of all, it works and it feels just right staying in the debugger to open JS files. https://cldup.com/gJCylgVnzW-3000x3000.png I noticed ~50 anonymous scripts on http://n12v.com. I don’t even know where are they coming from. Can we move them into a separate directory, same way it’s done in the resources sidebar? Comment on attachment 247536 [details] [PATCH] Progress patch for feedback. View in context: https://bugs.webkit.org/attachment.cgi?id=247536&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:348 > + // filter out those that were generated by the console. https://bugs.webkit.org/show_bug.cgi?id=142123 Comment on attachment 247536 [details] [PATCH] Progress patch for feedback. View in context: https://bugs.webkit.org/attachment.cgi?id=247536&action=review Overall the patch looks good. > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:353 > + // if (!script.url) > + // return; We should hide Anonymous Scripts for now. Then we can add support after filtering in in place. Created attachment 247980 [details]
[PATCH] Fix.
Comment on attachment 247980 [details] [PATCH] Fix. View in context: https://bugs.webkit.org/attachment.cgi?id=247980&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:332 > + this._getTreeElementForSourceCodeAndAddToContentTreeOutline(resource); _addTreeElementForSourceCodeToContentTreeOutline would be a better name, since we don't always use the result. Comment on attachment 247980 [details] [PATCH] Fix. View in context: https://bugs.webkit.org/attachment.cgi?id=247980&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:332 >> + this._getTreeElementForSourceCodeAndAddToContentTreeOutline(resource); > > _addTreeElementForSourceCodeToContentTreeOutline would be a better name, since we don't always use the result. That's much better. Created attachment 248083 [details]
[PATCH] Fix with additions for removing breakpoints.
I forgot to consider removing breakpoints. It was still the case that removing all breakpoints from a resource would cause the resource to be removed from the sidebar. This has been fixed with a change in TreeOutline.js and a small change to DebuggerSidebarPanel.js.
Comment on attachment 248083 [details] [PATCH] Fix with additions for removing breakpoints. View in context: https://bugs.webkit.org/attachment.cgi?id=248083&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:329 > + if ([WebInspector.Resource.Type.Document, WebInspector.Resource.Type.Script].indexOf(resource.type) < 0) Nit: .contains(resource.type) would be better. Committed r181184: <http://trac.webkit.org/changeset/181184> Reopening to attach new patch. Created attachment 248530 [details]
Patch, MISTAKENLY UPLOADED HERE
Mistakenly uploaded patch from another bug. |