Bug 141224

Summary: Every PageOverlayClientImpl leaks
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Tim Horton
Reported 2015-02-03 17:40:33 PST
Every PageOverlayClientImpl leaks
Attachments
Patch (9.16 KB, patch)
2015-02-03 17:40 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-02-03 17:40:51 PST
Created attachment 245997 [details] Patch
Tim Horton
Comment 2 2015-02-03 17:41:15 PST
rdar://problem/19652939
Simon Fraser (smfr)
Comment 3 2015-02-03 17:51:24 PST
Comment on attachment 245997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245997&action=review > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105 > + std::unique_ptr<Client> m_client; It's weird for thing to own its client, but perhaps this isn't a client in the normal sense.
Tim Horton
Comment 4 2015-02-03 17:56:42 PST
(In reply to comment #3) > Comment on attachment 245997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245997&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105 > > + std::unique_ptr<Client> m_client; > > It's weird for thing to own its client, but perhaps this isn't a client in > the normal sense. These are internal-ish client wrapper-ish things; it's not that weird, all of the API clients (Loader, Policy, etc.) on WKPage work exactly the same way.
Tim Horton
Comment 5 2015-02-03 17:58:37 PST
http://trac.webkit.org/changeset/179586
Note You need to log in before you can comment on or make changes to this bug.