| Summary: | Every PageOverlayClientImpl leaks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, mitz, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-02-03 17:40:33 PST
Created attachment 245997 [details]
Patch
Comment on attachment 245997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245997&action=review > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105 > + std::unique_ptr<Client> m_client; It's weird for thing to own its client, but perhaps this isn't a client in the normal sense. (In reply to comment #3) > Comment on attachment 245997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245997&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105 > > + std::unique_ptr<Client> m_client; > > It's weird for thing to own its client, but perhaps this isn't a client in > the normal sense. These are internal-ish client wrapper-ish things; it's not that weird, all of the API clients (Loader, Policy, etc.) on WKPage work exactly the same way. |