Bug 141219

Summary:

video.controls should not return true just because of fullscreen

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none

Description Eric Carlson 2015-02-03 16:42:32 PST

HTMLMediaElement::controls always returns true when an element is in fullscreen. While it may be necessary to show native controls when in fullscreen, video.controls should reflect the attribute value.

Comment 1 Eric Carlson 2015-02-03 16:43:50 PST

<rdar://problem/19237142>

Comment 2 Eric Carlson 2015-02-03 18:01:19 PST

Created attachment 246002 [details]
Proposed patch.

Comment 3 Dean Jackson 2015-02-04 08:24:36 PST

Comment on attachment 246002 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=246002&action=review

> Source/WebCore/ChangeLog:3
> +        video.attribute should not return true just because of fullscreen

Should this be "video.controls"?

Comment 4 WebKit Commit Bot 2015-02-04 10:16:12 PST

Comment on attachment 246002 [details]
Proposed patch.

Clearing flags on attachment: 246002

Committed r179612: <http://trac.webkit.org/changeset/179612>

Comment 5 WebKit Commit Bot 2015-02-04 10:16:16 PST

All reviewed patches have been landed.  Closing bug.