Bug 141219

Summary: video.controls should not return true just because of fullscreen
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2015-02-03 16:42:32 PST
HTMLMediaElement::controls always returns true when an element is in fullscreen. While it may be necessary to show native controls when in fullscreen, video.controls should reflect the attribute value.
Attachments
Proposed patch. (5.95 KB, patch)
2015-02-03 18:01 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-02-03 16:43:50 PST
<rdar://problem/19237142>
Eric Carlson
Comment 2 2015-02-03 18:01:19 PST
Created attachment 246002 [details] Proposed patch.
Dean Jackson
Comment 3 2015-02-04 08:24:36 PST
Comment on attachment 246002 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=246002&action=review > Source/WebCore/ChangeLog:3 > + video.attribute should not return true just because of fullscreen Should this be "video.controls"?
WebKit Commit Bot
Comment 4 2015-02-04 10:16:12 PST
Comment on attachment 246002 [details] Proposed patch. Clearing flags on attachment: 246002 Committed r179612: <http://trac.webkit.org/changeset/179612>
WebKit Commit Bot
Comment 5 2015-02-04 10:16:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.