| Summary: | Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cdumez, mitz, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 141233 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-02-03 16:23:25 PST
Created attachment 245986 [details]
Patch
Comment on attachment 245986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245986&action=review > Source/WebKit2/UIProcess/API/C/WKPage.h:217 > WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client); > +WK_EXPORT void WKPageSetPageNavigationClient(WKPageRef page, const WKPageNavigationClientBase* client); I think it would valuable to add a comment here explaining that you can either use WKPageSetPageNavigationClient or WKPageSetPageLoaderClient/WKPageSetPageLoaderClient. > Tools/WebKitTestRunner/TestController.cpp:97 > +static WKDataRef copyWebCryptoMasterKey(WKContextRef, const void*) > +{ > + return copyWebCryptoMasterKey(); > +} Why do we still need the Context variant of this in WKTR? (In reply to comment #2) > Comment on attachment 245986 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245986&action=review > > > Source/WebKit2/UIProcess/API/C/WKPage.h:217 > > WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client); > > +WK_EXPORT void WKPageSetPageNavigationClient(WKPageRef page, const WKPageNavigationClientBase* client); > > I think it would valuable to add a comment here explaining that you can > either use WKPageSetPageNavigationClient or > WKPageSetPageLoaderClient/WKPageSetPageLoaderClient. Sure! > > Tools/WebKitTestRunner/TestController.cpp:97 > > +static WKDataRef copyWebCryptoMasterKey(WKContextRef, const void*) > > +{ > > + return copyWebCryptoMasterKey(); > > +} > > Why do we still need the Context variant of this in WKTR? I don't think we do; good point! Oh dear, #import. Will fix. This broke both GTK and EFL (as the EWS show). (In reply to comment #7) > This broke both GTK and EFL (as the EWS show). Fixed in https://trac.webkit.org/changeset/179596. (In reply to comment #7) > This broke both GTK and EFL (as the EWS show). The failure I saw in EWS was fixed in r179589 but obviously wasn't the only problem. That said, WebKit2 yaddayadda. |