Bug 141185

Summary:

Web Platform Tests dirty a few untracked files

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, thorton, youennf

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Tim Horton

Reported 2015-02-02 19:19:55 PST

After a "run-webkit-tests -2": Untracked files: (use "git add <file>..." to include in what will be committed) LayoutTests/imported/w3c/web-platform-tests/_certs/index.txt LayoutTests/imported/w3c/web-platform-tests/tools/scripts/__init__.py LayoutTests/imported/w3c/web-platform-tests/tools/webdriver/webdriver/__init__.py I expect none of this!

Attachments
Patch (1.26 KB, patch) 2015-02-03 04:34 PST, youenn fablet	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2015-02-02 19:21:04 PST

Youenn, please fix your email address in contributors.json so that autocomplete for you works!

youenn fablet

Comment 2 2015-02-03 00:16:46 PST

(In reply to comment #1) > Youenn, please fix your email address in contributors.json so that > autocomplete for you works! Ah, right, I will fix it! Regarding the untracked files, the __init.py__ should have been checked in. It seems webkit infrastructure has some issues with empty files. Anyway, this should be covered by bug 141030 patch. I will fix the missing index.txt file.

youenn fablet

Comment 3 2015-02-03 04:34:12 PST

Created attachment 245932 [details] Patch

WebKit Commit Bot

Comment 4 2015-02-03 09:06:55 PST

Comment on attachment 245932 [details] Patch Rejecting attachment 245932 [details] from commit-queue. youennf@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

youenn fablet

Comment 5 2015-02-03 10:59:17 PST

(In reply to comment #1) > Youenn, please fix your email address in contributors.json so that > autocomplete for you works! Thanks for cq+!

WebKit Commit Bot

Comment 6 2015-02-03 11:34:53 PST

Comment on attachment 245932 [details] Patch Clearing flags on attachment: 245932 Committed r179557: <http://trac.webkit.org/changeset/179557>

WebKit Commit Bot

Comment 7 2015-02-03 11:34:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.