Bug 141176

Summary: [WK2] Drop legacy WKBundlePageDiagnosticLoggingClient API
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: REOPENED    
Severity: Normal CC: andersca, benjamin, commit-queue, ddkilzer, jer.noble, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=142129
Bug Depends on: 142131    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-02-02 14:55:47 PST
Drop legacy WKBundlePageDiagnosticLoggingClient WK2 API as we are now exposing this functionality via WKPageDiagnosticLoggingClient.h on UIProcess side. The client-side has already been ported over.
Attachments
Patch (45.48 KB, patch)
2015-02-27 11:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (45.50 KB, patch)
2015-02-27 11:46 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-02-23 18:48:46 PST
We should be able to drop this now.
Chris Dumez
Comment 2 2015-02-27 11:07:58 PST
Created attachment 247524 [details] Patch
Chris Dumez
Comment 3 2015-02-27 11:46:44 PST
Created attachment 247529 [details] Patch
WebKit Commit Bot
Comment 4 2015-02-27 17:43:44 PST
Comment on attachment 247529 [details] Patch Clearing flags on attachment: 247529 Committed r180804: <http://trac.webkit.org/changeset/180804>
WebKit Commit Bot
Comment 5 2015-02-27 17:43:51 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 6 2015-02-27 19:06:10 PST
Did this break two TestWebKitAPI tests? Build: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211> Test: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/logs/stdio> TIMEOUT _WKDownload.DownloadRequest TIMEOUT _WKDownload.OriginatingWebView
Chris Dumez
Comment 7 2015-02-27 19:31:43 PST
(In reply to comment #6) > Did this break two TestWebKitAPI tests? > > Build: > <https://build.webkit.org/builders/ > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211> > > Test: > <https://build.webkit.org/builders/ > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/ > logs/stdio> > > TIMEOUT _WKDownload.DownloadRequest > TIMEOUT _WKDownload.OriginatingWebView Seems unlikely. Also, it started failing after ryosuke's bmalloc changes, not mine, right?
Chris Dumez
Comment 8 2015-02-27 19:45:05 PST
(In reply to comment #7) > (In reply to comment #6) > > Did this break two TestWebKitAPI tests? > > > > Build: > > <https://build.webkit.org/builders/ > > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211> > > > > Test: > > <https://build.webkit.org/builders/ > > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/ > > logs/stdio> > > > > TIMEOUT _WKDownload.DownloadRequest > > TIMEOUT _WKDownload.OriginatingWebView > > Seems unlikely. Also, it started failing after ryosuke's bmalloc changes, > not mine, right? The build right after is good: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/3212 I guess this was a flake.
Alexey Proskuryakov
Comment 9 2015-02-28 10:33:23 PST
This broke nightly builds.
WebKit Commit Bot
Comment 10 2015-02-28 10:42:24 PST
Re-opened since this is blocked by bug 142131
Note You need to log in before you can comment on or make changes to this bug.