Bug 141170

Summary: Add diagnostic logging for ResourceResponse's source
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, japhet, kling, koivisto
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Chris Dumez
Reported 2015-02-02 14:11:02 PST
Add diagnostic logging for ResourceResponse's source (network, disk cache, disk cache after validation) to give us an idea of our network cache efficacy. Radar: <rdar://problem/19632080>
Attachments
Patch (6.40 KB, patch)
2015-02-02 14:15 PST, Chris Dumez 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-02-02 14:15:09 PST
Created attachment 245899 [details] Patch
Antti Koivisto
Comment 2 2015-02-02 17:14:53 PST
Comment on attachment 245899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245899&action=review > Source/WebCore/loader/ResourceLoader.cpp:300 > +static inline void logResourceResponseSource(Frame* frame, ResourceResponseBase::Source source) inline seems overkill
Antti Koivisto
Comment 3 2015-02-02 17:18:38 PST
Comment on attachment 245899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245899&action=review >> Source/WebCore/loader/ResourceLoader.cpp:300 >> +static inline void logResourceResponseSource(Frame* frame, ResourceResponseBase::Source source) > > inline seems overkill it is nicer to use ResourceResponse::Source, the Base is just an implementation detail.
Chris Dumez
Comment 4 2015-02-02 18:22:45 PST
Committed r179533: <http://trac.webkit.org/changeset/179533>
Note You need to log in before you can comment on or make changes to this bug.