Bug 141150

Summary:

[EFL] Add baselines for two region tests

Product:

WebKit

Reporter:

Kamil Nować <k.nowac>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

g.czajkowski, lucas.de.marchi, mcatanzaro

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	gyuyoung.kim: review+

Kamil Nować

Reported 2015-02-02 03:20:02 PST

Added some tests marked as Missing. * platform/efl/TestExpectations: * platform/efl/fast/regions/repaint/region-painting-invalidation-expected.png: Added. * platform/efl/fast/regions/repaint/region-painting-invalidation-expected.txt: Added. * platform/efl/fast/regions/repaint/region-painting-via-layout-expected.png: Added. * platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.

Attachments
Patch (6.45 KB, patch) 2015-02-02 03:42 PST, Kamil Nować	no flags	Details Formatted Diff Diff
Patch (4.70 KB, patch) 2015-02-02 06:54 PST, Kamil Nować	no flags	Details Formatted Diff Diff
Patch (4.52 KB, patch) 2015-02-02 07:45 PST, Kamil Nować	gyuyoung.kim: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kamil Nować

Comment 1 2015-02-02 03:42:08 PST

Created attachment 245866 [details] Patch

Kamil Nować

Comment 2 2015-02-02 06:54:44 PST

Created attachment 245873 [details] Patch

Krzysztof Czech

Comment 3 2015-02-02 07:01:33 PST

Comment on attachment 245873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245873&action=review > LayoutTests/ChangeLog:3 > + [EFL] Unreviewed EFL port gardening. This title should be exactly the same as bug's title. Now it's different > LayoutTests/ChangeLog:6 > + Added some tests marked as Missing. Seems you are adding new expectations rather than tests.

Kamil Nować

Comment 4 2015-02-02 07:45:32 PST

Created attachment 245874 [details] Patch

Kamil Nować

Comment 5 2015-02-02 07:47:24 PST

Change expectations for two region tests. * platform/efl/TestExpectations: * platform/efl/fast/regions/repaint/region-painting-invalidation-expected.txt: Added. * platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.

Krzysztof Czech

Comment 6 2015-02-02 07:52:41 PST

Comment on attachment 245874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245874&action=review > LayoutTests/ChangeLog:6 > + Change expectations for two region tests. Just one thing, could add the exact revision where those two tests were added. Would be easier to find those tests if needed.

Gyuyoung Kim

Comment 7 2015-02-03 07:56:35 PST

Comment on attachment 245874 [details] Patch Set r+ed to land after fixing Krzysztof's comment.

Michael Catanzaro

Comment 8 2017-03-11 10:33:26 PST

Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.

Note You need to log in before you can comment on or make changes to this bug.