Bug 141135

Summary: Clean up WebInspectorProxy and use simpler inspector levels design
Product: WebKit Reporter: Brian Burg <burg>
Component: WebKit2Assignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cgarcia, joepeck, kling, mrobinson, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141037    
Bug Blocks:    
Attachments:
Description Flags
Proposed Fix
none
Patch for EWS
none
Rebased Patch
none
Rebased Patch
none
Patch (fix iOS)
timothy: review+
Fix GTK,EFL
none
Fix GTK
none
Fix GTK none

Description Brian Burg 2015-02-01 00:10:48 PST
Patch forthcoming.
Comment 1 Brian Burg 2015-02-01 00:25:50 PST
Created attachment 245824 [details]
Proposed Fix

Patch is rebased on top of conversion to WKWebView, so will reupload when ready.
Comment 2 Brian Burg 2015-02-02 22:06:45 PST
Created attachment 245925 [details]
Patch for EWS
Comment 3 Brian Burg 2015-02-03 15:44:45 PST
Created attachment 245980 [details]
Rebased Patch
Comment 4 Brian Burg 2015-02-03 21:05:26 PST
Created attachment 246013 [details]
Rebased Patch
Comment 5 Brian Burg 2015-02-04 09:37:32 PST
Created attachment 246036 [details]
Patch (fix iOS)
Comment 6 Timothy Hatcher 2015-02-04 14:11:21 PST
Comment on attachment 246036 [details]
Patch (fix iOS)

Looks good. Just a couple of page() -> inspectorPage() changes in EFL and Gtk you missed.
Comment 7 Brian Burg 2015-02-05 08:51:56 PST
Created attachment 246103 [details]
Fix GTK,EFL
Comment 8 Brian Burg 2015-02-05 09:07:08 PST
Created attachment 246105 [details]
Fix GTK
Comment 9 Brian Burg 2015-02-05 13:10:50 PST
Created attachment 246126 [details]
Fix GTK
Comment 10 Brian Burg 2015-02-05 13:52:15 PST
Committed r179705: <http://trac.webkit.org/changeset/179705>