Summary: | Clean up WebInspectorProxy and use simpler inspector levels design | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||||||||||||
Component: | WebKit2 | Assignee: | Brian Burg <burg> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | andersca, benjamin, cgarcia, joepeck, kling, mrobinson, timothy | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | 141037 | ||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||
Attachments: |
|
Description
Brian Burg
2015-02-01 00:10:48 PST
Created attachment 245824 [details]
Proposed Fix
Patch is rebased on top of conversion to WKWebView, so will reupload when ready.
Created attachment 245925 [details]
Patch for EWS
Created attachment 245980 [details]
Rebased Patch
Created attachment 246013 [details]
Rebased Patch
Created attachment 246036 [details]
Patch (fix iOS)
Comment on attachment 246036 [details]
Patch (fix iOS)
Looks good. Just a couple of page() -> inspectorPage() changes in EFL and Gtk you missed.
Created attachment 246103 [details]
Fix GTK,EFL
Created attachment 246105 [details]
Fix GTK
Created attachment 246126 [details]
Fix GTK
Committed r179705: <http://trac.webkit.org/changeset/179705> |