Bug 141109

Summary:

Clean up attribute handling: part 2 - attributeNode

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, esprehn+autocc, kangil.han

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Benjamin Poulain 2015-01-30 19:46:00 PST

Clean up attribute handling: part 2 - attributeNode

Comment 1 Benjamin Poulain 2015-01-30 20:17:28 PST

Created attachment 245769 [details]
Patch

Comment 2 Benjamin Poulain 2015-02-02 13:05:34 PST

Created attachment 245895 [details]
Patch

Comment 3 Andreas Kling 2015-02-02 13:52:22 PST

Comment on attachment 245895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245895&action=review

r=me

> Source/WebCore/dom/Element.cpp:1764
> +    return oldAttrNode.release();

We can get rid of the .release() here.

> Source/WebCore/dom/Element.cpp:1835
>      return attrNode.release();

Here too.

Comment 4 Benjamin Poulain 2015-02-02 14:00:45 PST

Committed r179497: <http://trac.webkit.org/changeset/179497>