Bug 141109

Summary: Clean up attribute handling: part 2 - attributeNode
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Benjamin Poulain
Reported 2015-01-30 19:46:00 PST
Clean up attribute handling: part 2 - attributeNode
Attachments
Patch (158.84 KB, patch)
2015-01-30 20:17 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (162.63 KB, patch)
2015-02-02 13:05 PST, Benjamin Poulain 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-01-30 20:17:28 PST
Created attachment 245769 [details] Patch
Benjamin Poulain
Comment 2 2015-02-02 13:05:34 PST
Created attachment 245895 [details] Patch
Andreas Kling
Comment 3 2015-02-02 13:52:22 PST
Comment on attachment 245895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245895&action=review r=me > Source/WebCore/dom/Element.cpp:1764 > + return oldAttrNode.release(); We can get rid of the .release() here. > Source/WebCore/dom/Element.cpp:1835 > return attrNode.release(); Here too.
Benjamin Poulain
Comment 4 2015-02-02 14:00:45 PST
Committed r179497: <http://trac.webkit.org/changeset/179497>
Note You need to log in before you can comment on or make changes to this bug.