Bug 141109 - Clean up attribute handling: part 2 - attributeNode
Summary: Clean up attribute handling: part 2 - attributeNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 19:46 PST by Benjamin Poulain
Modified: 2015-02-02 14:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (158.84 KB, patch)
2015-01-30 20:17 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (162.63 KB, patch)
2015-02-02 13:05 PST, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-01-30 19:46:00 PST 
Clean up attribute handling: part 2 - attributeNode
Comment 1 Benjamin Poulain 2015-01-30 20:17:28 PST 
Created attachment 245769 [details]
Patch
Comment 2 Benjamin Poulain 2015-02-02 13:05:34 PST 
Created attachment 245895 [details]
Patch
Comment 3 Andreas Kling 2015-02-02 13:52:22 PST 
Comment on attachment 245895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245895&action=review

r=me

> Source/WebCore/dom/Element.cpp:1764
> +    return oldAttrNode.release();

We can get rid of the .release() here.

> Source/WebCore/dom/Element.cpp:1835
>      return attrNode.release();

Here too.
Comment 4 Benjamin Poulain 2015-02-02 14:00:45 PST 
Committed r179497: <http://trac.webkit.org/changeset/179497>