Summary: | Simple line layout: Improve FlowContentsIterator::TextFragment's encapsulation. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan, mmaxfield | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2015-01-30 11:41:43 PST
Created attachment 245729 [details]
Patch
Comment on attachment 245729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245729&action=review Nice :) r=me > Source/WebCore/rendering/SimpleLineLayoutFlowContentsIterator.h:66 > + unsigned m_end { 0 }; Might as well fix the double space before { here. Created attachment 245770 [details]
Patch
Created attachment 245771 [details]
Patch
Comment on attachment 245771 [details] Patch Clearing flags on attachment: 245771 Committed r179438: <http://trac.webkit.org/changeset/179438> All reviewed patches have been landed. Closing bug. This caused a crash (assertion failure): https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt Alan, Andreas, do you happen to be available to investigate soon? (In reply to comment #7) > This caused a crash (assertion failure): > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/ > r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt > > Alan, Andreas, do you happen to be available to investigate soon? Thanks. Looking at it now. (In reply to comment #7) > This caused a crash (assertion failure): > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/ > r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt > > Alan, Andreas, do you happen to be available to investigate soon? Bug 141121 |