Bug 141076

Summary: [cairo] Fix #if guards in platform/graphics/cairo directory
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Csaba Osztrogonác 2015-01-30 03:25:41 PST 
problems in nutshell:
- missing USE(CAIRO) guards
- guards in wrong place
- missing comments for namespace end and #endif
- ...
Comment 1 Csaba Osztrogonác 2015-01-30 03:27:03 PST 
Created attachment 245707 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-01-30 03:54:28 PST 
Created attachment 245708 [details]
Patch

typo fixed in OwnPtrCairo.h
Comment 3 Sergio Villar Senin 2015-01-30 05:43:22 PST 
Comment on attachment 245708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245708&action=review

Really. Nice. Stuff.

> Source/WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp:-66
> -// vim: ts=4 sw=4 et

:O
Comment 4 Csaba Osztrogonác 2015-01-30 05:56:55 PST 
Comment on attachment 245708 [details]
Patch

Clearing flags on attachment: 245708

Committed r179398: <http://trac.webkit.org/changeset/179398>
Comment 5 Csaba Osztrogonác 2015-01-30 05:57:02 PST 
All reviewed patches have been landed.  Closing bug.