Bug 141076

Summary: [cairo] Fix #if guards in platform/graphics/cairo directory
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-01-30 03:25:41 PST
problems in nutshell: - missing USE(CAIRO) guards - guards in wrong place - missing comments for namespace end and #endif - ...
Attachments
Patch (22.28 KB, patch)
2015-01-30 03:27 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (22.29 KB, patch)
2015-01-30 03:54 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-01-30 03:27:03 PST
Created attachment 245707 [details] Patch
Csaba Osztrogonác
Comment 2 2015-01-30 03:54:28 PST
Created attachment 245708 [details] Patch typo fixed in OwnPtrCairo.h
Sergio Villar Senin
Comment 3 2015-01-30 05:43:22 PST
Comment on attachment 245708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245708&action=review Really. Nice. Stuff. > Source/WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp:-66 > -// vim: ts=4 sw=4 et :O
Csaba Osztrogonác
Comment 4 2015-01-30 05:56:55 PST
Comment on attachment 245708 [details] Patch Clearing flags on attachment: 245708 Committed r179398: <http://trac.webkit.org/changeset/179398>
Csaba Osztrogonác
Comment 5 2015-01-30 05:57:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.