Bug 141069

Summary:

Optimize MemoryCache::getSessionMap() a bit

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, commit-queue, darin, japhet, kling, koivisto, mhock

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

141091

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2015-01-29 22:34:52 PST

Optimize MemoryCache::getSessionMap() a bit

Attachments
Patch (5.22 KB, patch) 2015-01-29 22:38 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.89 KB, patch) 2015-01-30 14:47 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.94 KB, patch) 2015-01-30 16:15 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.94 KB, patch) 2015-01-30 16:45 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2015-01-29 22:38:06 PST

Created attachment 245696 [details] Patch

Anders Carlsson

Comment 2 2015-01-30 07:19:11 PST

Comment on attachment 245696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245696&action=review > Source/WebCore/loader/cache/MemoryCache.cpp:80 > + std::unique_ptr<CachedResourceMap>& map = m_sessionResources.add(sessionID, nullptr).iterator->value; auto& map = > Source/WebCore/loader/cache/MemoryCache.h:187 > - CachedResourceMap& getSessionMap(SessionID); > + CachedResourceMap& sessionResources(SessionID = SessionID::defaultSessionID()); I think it's better to be explicit about which session we want here, otherwise it's easy to always use the default session.

Chris Dumez

Comment 3 2015-01-30 09:43:41 PST

Committed r179403: <http://trac.webkit.org/changeset/179403>

Alexey Proskuryakov

Comment 4 2015-01-30 12:37:54 PST

This caused a crash: https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r179403%20(10178)/fast/files/workers/worker-apply-blob-url-to-xhr-crash-log.txt

WebKit Commit Bot

Comment 5 2015-01-30 12:42:06 PST

Re-opened since this is blocked by bug 141091

Chris Dumez

Comment 6 2015-01-30 14:02:08 PST

Rolled out in <http://trac.webkit.org/changeset/179410>. I'll propose another fix.