Bug 141064

Summary: Web Inspector: Extend CSS.getSupportedCSSProperties to provide values for properties for CSS Augmented JSContext
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-01-29 18:36:46 PST 
* SUMMARY
For a CSS Augmented JSContext it can provide custom CSS properties via CSS.getSupportedCSSProperties. If that is the case, they can provide custom autocompletion values.
Comment 1 Joseph Pecoraro 2015-01-29 18:37:10 PST 
<rdar://problem/19640303>
Comment 2 Joseph Pecoraro 2015-01-29 18:51:54 PST 
Created attachment 245682 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-01-30 04:51:49 PST 
Comment on attachment 245682 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=245682&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94
> +    WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()];

[...existingValues, ...newValues]?
Comment 4 Joseph Pecoraro 2015-02-02 11:21:58 PST 
(In reply to comment #3)
> Comment on attachment 245682 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245682&action=review
> 
> > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94
> > +    WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()];
> 
> [...existingValues, ...newValues]?

I wanted to avoid duplicates in the list if possible.
Comment 5 WebKit Commit Bot 2015-02-02 12:06:58 PST 
Comment on attachment 245682 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245682

Committed r179483: <http://trac.webkit.org/changeset/179483>
Comment 6 WebKit Commit Bot 2015-02-02 12:07:01 PST 
All reviewed patches have been landed.  Closing bug.