Bug 141062

Summary: REGRESSION(r179357): Suspect this caused WebGL tests to start flaking (Requested by kling on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, fpizlo, ggaren, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140660    
Attachments:
Description Flags
ROLLOUT of r179357 none

Description WebKit Commit Bot 2015-01-29 17:26:17 PST
http://trac.webkit.org/changeset/179357 broke the build:
Suspect this caused WebGL tests to start flaking (Requested by kling on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2015-01-29 17:26:49 PST
Created attachment 245676 [details]
ROLLOUT of r179357

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Filip Pizlo 2015-01-29 18:08:14 PST
Can you explain why r179357 is being blamed for the flakes?
Comment 3 Andreas Kling 2015-01-29 18:22:19 PST
(In reply to comment #2)
> Can you explain why r179357 is being blamed for the flakes?

Looky:

https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29?numbuilds=50

Some WebGL tests have either failed or flaked on every run since 179357.
Comment 4 Andreas Kling 2015-01-29 20:28:38 PST
Comment on attachment 245676 [details]
ROLLOUT of r179357

Clearing flags on attachment: 245676

Committed r179392: <http://trac.webkit.org/changeset/179392>
Comment 5 Andreas Kling 2015-01-29 20:28:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2015-01-29 22:51:31 PST
Interestingly, inspector/css/selector-specificity.html crashed on the bots after this roll out (it may be a flake):

https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r179392%20(11150)/results.html
https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r179392%20(1911)/results.html