Bug 141061

Summary: Remote Web Inspector should not show undock toolbar buttons
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-01-29 17:16:55 PST
* SUMMARY Remote Web Inspector should not show undock toolbar buttons. * STEPS TO REPRODUCE 1. Remote Inspect iOS 8 MobileSafari or JSContext => frontend has undock buttons
Attachments
[PATCH] Proposed Fix (1.41 KB, patch)
2015-01-29 17:26 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-01-29 17:17:12 PST
<rdar://problem/19656961>
Joseph Pecoraro
Comment 2 2015-01-29 17:24:31 PST
Looks like this broke with: https://trac.webkit.org/changeset/173929 That removed: // Update the docked state based on the query string passed when the Web Inspector was loaded. this.updateDockedState(parseLocationQueryParameters().dockSide || "undocked"); Which caused the buttons to never update as "undocked" and therefore hidden. Easy fix.
Joseph Pecoraro
Comment 3 2015-01-29 17:26:31 PST
Created attachment 245675 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 4 2015-01-30 04:54:56 PST
Comment on attachment 245675 [details] [PATCH] Proposed Fix Oops! Thanks!
WebKit Commit Bot
Comment 5 2015-01-30 15:56:42 PST
Comment on attachment 245675 [details] [PATCH] Proposed Fix Clearing flags on attachment: 245675 Committed r179418: <http://trac.webkit.org/changeset/179418>
WebKit Commit Bot
Comment 6 2015-01-30 15:56:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.