Bug 141050

Summary: Remove more Mountain Lion code from WebKit
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, bdakin, mitz, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Beth Dakin 2015-01-29 14:29:15 PST 
Remove more Mountain Lion code from WebKit
Comment 1 Beth Dakin 2015-01-29 14:30:40 PST 
Created attachment 245650 [details]
Patch
Comment 2 Anders Carlsson 2015-01-29 15:56:30 PST 
Comment on attachment 245650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245650&action=review

> Source/WebKit/mac/WebView/WebFrameView.mm:103
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).

> Source/WebKit/mac/WebView/WebFrameView.mm:549
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).

> Source/WebKit/mac/WebView/WebPreferences.mm:2356
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).

> Source/WebKit/mac/WebView/WebView.mm:2204
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).
Comment 3 Beth Dakin 2015-01-29 16:02:56 PST 
Fixed all of these. Thanks! http://trac.webkit.org/changeset/179376

(In reply to comment #2)
> Comment on attachment 245650 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245650&action=review
> 
> > Source/WebKit/mac/WebView/WebFrameView.mm:103
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).
> 
> > Source/WebKit/mac/WebView/WebFrameView.mm:549
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).
> 
> > Source/WebKit/mac/WebView/WebPreferences.mm:2356
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).
> 
> > Source/WebKit/mac/WebView/WebView.mm:2204
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).