Bug 141050

Summary: Remove more Mountain Lion code from WebKit
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, bdakin, mitz, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Beth Dakin
Reported 2015-01-29 14:29:15 PST
Remove more Mountain Lion code from WebKit
Attachments
Patch (11.65 KB, patch)
2015-01-29 14:30 PST, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2015-01-29 14:30:40 PST
Created attachment 245650 [details] Patch
Anders Carlsson
Comment 2 2015-01-29 15:56:30 PST
Comment on attachment 245650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245650&action=review > Source/WebKit/mac/WebView/WebFrameView.mm:103 > +#if !PLATFORM(IOS) I think this should be #if PLATFORM(MAC). > Source/WebKit/mac/WebView/WebFrameView.mm:549 > +#if !PLATFORM(IOS) I think this should be #if PLATFORM(MAC). > Source/WebKit/mac/WebView/WebPreferences.mm:2356 > +#if !PLATFORM(IOS) I think this should be #if PLATFORM(MAC). > Source/WebKit/mac/WebView/WebView.mm:2204 > +#if !PLATFORM(IOS) I think this should be #if PLATFORM(MAC).
Beth Dakin
Comment 3 2015-01-29 16:02:56 PST
Fixed all of these. Thanks! http://trac.webkit.org/changeset/179376 (In reply to comment #2) > Comment on attachment 245650 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245650&action=review > > > Source/WebKit/mac/WebView/WebFrameView.mm:103 > > +#if !PLATFORM(IOS) > > I think this should be #if PLATFORM(MAC). > > > Source/WebKit/mac/WebView/WebFrameView.mm:549 > > +#if !PLATFORM(IOS) > > I think this should be #if PLATFORM(MAC). > > > Source/WebKit/mac/WebView/WebPreferences.mm:2356 > > +#if !PLATFORM(IOS) > > I think this should be #if PLATFORM(MAC). > > > Source/WebKit/mac/WebView/WebView.mm:2204 > > +#if !PLATFORM(IOS) > > I think this should be #if PLATFORM(MAC).
Note You need to log in before you can comment on or make changes to this bug.