Bug 141050 - Remove more Mountain Lion code from WebKit
Summary: Remove more Mountain Lion code from WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-29 14:29 PST by Beth Dakin
Modified: 2015-01-29 16:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.65 KB, patch)
2015-01-29 14:30 PST, Beth Dakin 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-01-29 14:29:15 PST 
Remove more Mountain Lion code from WebKit
Comment 1 Beth Dakin 2015-01-29 14:30:40 PST 
Created attachment 245650 [details]
Patch
Comment 2 Anders Carlsson 2015-01-29 15:56:30 PST 
Comment on attachment 245650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245650&action=review

> Source/WebKit/mac/WebView/WebFrameView.mm:103
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).

> Source/WebKit/mac/WebView/WebFrameView.mm:549
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).

> Source/WebKit/mac/WebView/WebPreferences.mm:2356
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).

> Source/WebKit/mac/WebView/WebView.mm:2204
> +#if !PLATFORM(IOS)

I think this should be #if PLATFORM(MAC).
Comment 3 Beth Dakin 2015-01-29 16:02:56 PST 
Fixed all of these. Thanks! http://trac.webkit.org/changeset/179376

(In reply to comment #2)
> Comment on attachment 245650 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245650&action=review
> 
> > Source/WebKit/mac/WebView/WebFrameView.mm:103
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).
> 
> > Source/WebKit/mac/WebView/WebFrameView.mm:549
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).
> 
> > Source/WebKit/mac/WebView/WebPreferences.mm:2356
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).
> 
> > Source/WebKit/mac/WebView/WebView.mm:2204
> > +#if !PLATFORM(IOS)
> 
> I think this should be #if PLATFORM(MAC).