| Summary: | Move HAVE_DTRACE definition back to Platform.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Blocker | CC: | benjamin, cgarcia, cmarcelo, commit-queue, mitz, ossy | ||||||
| Priority: | P1 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 141027 | ||||||||
| Attachments: |
|
||||||||
|
Description
Csaba Osztrogonác
2015-01-29 07:37:05 PST
Created attachment 245619 [details]
Patch
Created attachment 245620 [details]
Patch
Comment on attachment 245620 [details]
Patch
dtrace is more of an OS(DARWIN) thing than a PLATFORM(COCOA) thing, I think.
(In reply to comment #4) > Comment on attachment 245620 [details] > Patch > > dtrace is more of an OS(DARWIN) thing than a PLATFORM(COCOA) thing, I think. There is GTK on OS(DARWIN) and GTK maybe don't want to ship dtrace. Additionally it was defined for only Mac/iOS in xcconfig, I can't see the reason why should we change this behaviour. ping? Comment on attachment 245620 [details]
Patch
Seems reasonable. Someone else can update the JavaScriptCore project to use a native Xcode build rule for generating the header, now that it’s unconditional.
Let's land it now as is, the xcode project file can be polished later. Comment on attachment 245620 [details] Patch Clearing flags on attachment: 245620 Committed r179345: <http://trac.webkit.org/changeset/179345> All reviewed patches have been landed. Closing bug. new bug report for polishing: bug141036 |