Bug 141024

Summary: Rename 'usesArguments' to 'setUsesArguments' in ASTBuilder
Product: WebKit Reporter: Han Choongwoo <cwhan.tunz>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Trivial CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review-

Description Han Choongwoo 2015-01-28 19:46:34 PST 
The method name 'usesArguments' in ASTBuilder is confusing.
'usesArguments' is used as setter method in AST Builder.
In other files, usesArguments is getter method,
and 'setUsesArguments' is setter method.

So, it is better to rename usesArguments to setUsesArguments in ASTBuilder.
Comment 1 Han Choongwoo 2015-01-28 19:48:59 PST 
Created attachment 245604 [details]
Patch
Comment 2 Darin Adler 2015-02-04 09:16:11 PST 
Comment on attachment 245604 [details]
Patch

I don’t think it makes sense to change this function and not change the 4 other similarly-named ones, usesThis, usesCatch, usesWith, and usesEval. You should talk to the programmers who work on this code a lot and see if they are amendable to renaming all 5 of them.
Comment 3 Darin Adler 2015-02-04 09:16:40 PST 
(In reply to comment #2)
> amendable

I meant "amenable"