Bug 141024

Summary: Rename 'usesArguments' to 'setUsesArguments' in ASTBuilder
Product: WebKit Reporter: Han Choongwoo <cwhan.tunz>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Trivial CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review-

Han Choongwoo
Reported 2015-01-28 19:46:34 PST
The method name 'usesArguments' in ASTBuilder is confusing. 'usesArguments' is used as setter method in AST Builder. In other files, usesArguments is getter method, and 'setUsesArguments' is setter method. So, it is better to rename usesArguments to setUsesArguments in ASTBuilder.
Attachments
Patch (2.88 KB, patch)
2015-01-28 19:48 PST, Han Choongwoo 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Han Choongwoo
Comment 1 2015-01-28 19:48:59 PST
Created attachment 245604 [details] Patch
Darin Adler
Comment 2 2015-02-04 09:16:11 PST
Comment on attachment 245604 [details] Patch I don’t think it makes sense to change this function and not change the 4 other similarly-named ones, usesThis, usesCatch, usesWith, and usesEval. You should talk to the programmers who work on this code a lot and see if they are amendable to renaming all 5 of them.
Darin Adler
Comment 3 2015-02-04 09:16:40 PST
(In reply to comment #2) > amendable I meant "amenable"
Note You need to log in before you can comment on or make changes to this bug.