Bug 141015

Summary:

asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address

Product:

WebKit

Reporter:

Dana Burkart <dburkart>

Component:

Tools / Tests

Assignee:

Dana Burkart <dburkart>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, dburkart, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES	ap: review+

Dana Burkart

Reported 2015-01-28 15:36:18 PST

We should use CLANG_ADDRESS_SANITIZER=YES to build with ASan, since we use xcodebuild to do all of our (mac) building.

Attachments
Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES (1.23 KB, patch) 2015-01-28 15:45 PST, Dana Burkart	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dana Burkart

Comment 1 2015-01-28 15:45:48 PST

Created attachment 245573 [details] Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES

Alexey Proskuryakov

Comment 2 2015-01-28 16:19:54 PST

Comment on attachment 245573 [details] Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES So we can remove ASAN_OTHER_LDFLAGS from everywhere now?

Dana Burkart

Comment 3 2015-01-28 16:21:26 PST

(In reply to comment #2) > Comment on attachment 245573 [details] > Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES > > So we can remove ASAN_OTHER_LDFLAGS from everywhere now? Yeah, I don't see why not.

Dana Burkart

Comment 4 2015-01-28 16:30:19 PST

Resolved in r179312.

Note You need to log in before you can comment on or make changes to this bug.