Bug 140981

Summary: Use an enum class for createFontFamilyValue()'s fromSystemFontID argument
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-01-27 20:03:45 PST
Use an enum class for createFontFamilyValue()'s fromSystemFontID argument instead of a simple enum.
Attachments
Patch (5.43 KB, patch)
2015-01-27 20:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-27 20:07:18 PST
Created attachment 245511 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-27 20:09:49 PST
Attachment 245511 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSValuePool.cpp:132: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2015-01-28 10:24:49 PST
Comment on attachment 245511 [details] Patch Clearing flags on attachment: 245511 Committed r179267: <http://trac.webkit.org/changeset/179267>
WebKit Commit Bot
Comment 4 2015-01-28 10:24:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.