Summary: | Rename descendentxxx to descendantxxxx in RenderLayerBacking | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeongmin Kim <jm86.kim> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, sun.shin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jeongmin Kim
2015-01-27 19:32:58 PST
Created attachment 245507 [details]
Patch
Created attachment 245510 [details]
Patch
Thanks for doing this, but I'm not sure it's quite accurate. FYI, the dictionary says: "usage: The correct spelling for the noun meaning ‘person descended from a particular ancestor’ is descendant, ending with the suffix -ant, not -ent (as in she claims to be a descendant of Paul Revere). The word descendent is an adjective, now used almost exclusively in scientific contexts, meaning ‘descending from an ancestor’ (as in extinct species are replaced by descendent species). Almost 15 percent of the citations for the noun in the Oxford English Corpus use the wrong spelling." Our usage sometimes follows the adjectival form, so I don't think we're using the -ent for incorrectly. @Simon, we are totally agree with your idea. However, from a debugging perspective, it is a little hard to track logic if there are two different words are used for same meaning in a one file. So, we want to enhance the readability of the code itself. I do not object to the patch. I think consistency is good. Comment on attachment 245510 [details] Patch Clearing flags on attachment: 245510 Committed r179244: <http://trac.webkit.org/changeset/179244> All reviewed patches have been landed. Closing bug. |